Repository navigation
Conversation
Contributor
|
Are we sure this is actually a thread id? Seems odd to initialize it to 0x8000. |
Contributor
Author
|
Yes absolutely positive this is the thread id from behavior of many titles. 0x8000 is a weird thread if for "not numbered", but this is the thread id. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously OSThread.id claimed it was a unique thread id, but it's always initialized to 0x8000 on all threads, so not only not unique, but callers can assign custom ids to it (which is not clear).
This just updates the documentation to make both of those more clear.