Repository navigation
Conversation
…generate them IntelliJ opens a table with ORDER BY "date" (it quotes a reserved-word column with the standard double quote), which a back-tick-only connection could not parse. getIdentifierQuoteString now reports the quote the parser accepts. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
dfa1
force-pushed
the
fix/sql-double-quote-identifiers
branch
from
October 20, 2026 20:14
4ca8059 to
9cc7d16
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IntelliJ's table editor opens a table with
ORDER BY "date"; the connection only parsed back-ticks, so double-clickingohlcfailed. The connection now uses Calcite's DOUBLE_QUOTE quoting (case sensitivity unchanged), sogetIdentifierQuoteString()reports".Breaking: back-ticked identifiers no longer parse; docs and tests moved to double quotes. Verified against the rebuilt
-alljar:ORDER BY "date" DESCruns,dateis a lexical error.Tests: calcite 206, jdbc-driver 19, CalciteInteropIntegrationTest 55 (vortex-jni cross-check) pass.
🤖 Generated with Claude Code