Skip to content

build(e2e): upgrade Playwright to 1.64.1 for Ubuntu 26.04 runners - #685

Merged
aterga merged 2 commits into
mainfrom
chore/upgrade-playwright-ubuntu-26.04
Nov 17, 2026
Merged

aterga merged 2 commits into
mainfrom
chore/upgrade-playwright-ubuntu-26.04

Conversation

@aterga

@aterga aterga commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

e2e-tests:required fails on main since ubuntu-latest moved to Ubuntu 26.04 (failing run). Playwright 1.59.1 refuses to install browsers there, so no test runs:

Error: ERROR: Playwright does not support chromium on ubuntu26.04-x64

Playwright supports Ubuntu 26.04 since 1.63 (ubuntu26.04-x64 is in playwright-core's host platform and dependency tables from 1.63.0 on). Every e2e run until 2026-11-10 passed on the previous image.

Changes

  • package.json: @playwright/test ^1.55.1 → ~1.64.1.
  • pnpm-lock.yaml: @playwright/test, playwright and playwright-core 1.59.1 → 1.64.1, nothing else. pnpm install --frozen-lockfile accepts it. The docs site's separate playwright 1.55.1 pin is unchanged.
  • tests.yaml: a step before the e2e run installs the browsers the e2e projects use (chromium, firefox) with --with-deps, so a future runner image can't leave them without their system libraries. The local test:e2e script is unchanged, so local runs still don't need sudo.

Testing

The e2e job on this PR runs on ubuntu-latest (26.04) with the new version.

Why 1.64 and not 1.65

Playwright 1.65.0 no longer tests on Node.js 20 ("Use Node.js 22, 24 or 26"), and this repository pins Node 20 (.nvmrc, engines.node). 1.64.1 supports Ubuntu 26.04 and does not drop Node 20, so the range is ~1.64.1 until the repository moves to Node 22.

https://claude.ai/code/session_01VP2vTHJDxWCtmbSkf3682e


Generated by Claude Code

ubuntu-latest now resolves to Ubuntu 26.04, and Playwright 1.59.1 refuses to
install browsers there ("Playwright does not support chromium on
ubuntu26.04-x64"), so e2e-tests:required fails before any test runs.
Playwright supports Ubuntu 26.04 since 1.63.

Upgrade @playwright/test to ^1.65.1 (lockfile: the three Playwright packages
only), and install the browsers the e2e projects use with their OS packages
in CI before running the tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VP2vTHJDxWCtmbSkf3682e
Copilot AI max review requested due to automatic review settings November 16, 2026 15:30
@aterga
aterga marked this pull request as ready for review November 16, 2026 15:31
@aterga
aterga requested a review from a team as a code owner November 16, 2026 15:31
@zeropath-ai

zeropath-ai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

✅ No security or compliance issues detected. Reviewed everything up to fa325e5.

Security Overview
Detected Code Changes
Change Type Relevant files
Enhancement ► .github/workflows/tests.yaml
    Install Playwright browsers for e2e tests
► package.json
    Bump @playwright/test from ^1.55.1 to ~1.64.1
► pnpm-lock.yaml
    Update Playwright-related dependencies to 1.64.1 and adjust node engines accordingly

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Playwright 1.65 no longer tests Node.js 20, but CI still uses the repository’s Node.js 20.18 pin, so the dependency version or repository runtime constraints need to be aligned.

1 open issue
1 file not reviewed
  • pnpm-lock.yaml: Generated file
What changed in this PR

Updates the end-to-end test tooling to address browser-install failures after ubuntu-latest moved to Ubuntu 26.04.

Changes:

  • Upgrades @playwright/test and its locked dependencies to 1.65.1.
  • Adds browser and system-dependency installation in CI while leaving the local test script unchanged.
File Description
pnpm-lock.yaml Updates e2e Playwright packages while preserving the docs site's separate version.
package.json Raises the @playwright/test dependency range to ^1.65.1.
.github/​workflows/​tests.yaml Installs Chromium, Firefox, and their system dependencies before e2e tests.

Review effort: Max

Comment thread package.json Resolved
Playwright 1.65.0 no longer tests on Node.js 20 ("Use Node.js 22, 24 or 26"),
and the repository pins Node 20 (.nvmrc, engines.node ^20), which the e2e job
uses through setup-node. 1.64.1 already supports Ubuntu 26.04 (since 1.63) and
does not drop Node 20, so pin ~1.64.1 until the repository moves to Node 22.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VP2vTHJDxWCtmbSkf3682e
Copilot AI max review requested due to automatic review settings November 16, 2026 15:40
@aterga aterga changed the title build(e2e): upgrade Playwright to 1.65.1 for Ubuntu 26.04 runners build(e2e): upgrade Playwright to 1.64.1 for Ubuntu 26.04 runners Nov 16, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The CI job still runs an unrestricted Playwright install through test:e2e, causing a redundant installation pass and downloading unused WebKit.

No open issues 🎉

1 previously missed issue

In code that hasn't changed since last review

Low severity Avoid redundant Playwright install and unused WebKit download

.github/​workflows/​tests.yaml:198

Optional: test:e2e still starts with an unrestricted playwright install, so this job performs a second install pass and also downloads unused WebKit. Have the next step invoke the existing deploy/run/stop scripts directly so browser installation is handled only here, without changing local test:e2e behavior.

1 resolved since last review
1 file not reviewed
  • pnpm-lock.yaml: Generated file

Review effort: Max

@aterga
aterga merged commit da9e072 into main Nov 17, 2026
54 checks passed
@aterga
aterga deleted the chore/upgrade-playwright-ubuntu-26.04 branch November 17, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants