Repository navigation
hosted build: stripe-fake.ts declares the charge route twice after #1425 and #1426 merged #1428
Description
pnpm build fails at hosted's tsc --noEmit on main, because hosted/server/tests/stripe-fake.ts declares the /v1/charges/ch_for_<id> route twice:
server/tests/stripe-fake.ts(79,11): error TS2451: Cannot redeclare block-scoped variable 'charge'.
server/tests/stripe-fake.ts(85,11): error TS2451: Cannot redeclare block-scoped variable 'charge'.
Two PRs each added the same fake Stripe charge route, and they merged a minute apart with no textual conflict: #1425 (via fda0256, "give dispute events their charge") and #1426 (via d89cc93, which also adds the disputedCharge helper). Merge commit 5cd5ff0 kept both blocks. The two handlers behave identically, so the fix is to delete the second one, which inlines the charge body, and keep #1426's version that calls disputedCharge.
Failing run: 40813938991, job Build & Test, step Build. The build stops at this error, so it hides any later steps of that job that might also fail.
Cause of a failure tracked in #1427.
Activity
dormouse-bot commentedon Oct 29, 2026
#1429 deletes the second
ch_for_<id>charge route and keeps #1426's handler, which callsdisputedCharge. The two handlers returned the same body and the same 404, so tests behave the same. On its head9a5ad94,Build & Test(which runs thehostedtypecheck that failed here),verify, and the other checks pass. The bot review is still running, and merging is up to a maintainer.