Skip to content

URL options for embedding (?robot, ?onboarding=off); Record disabled while nothing runs - #6

Draft
mustafab0 wants to merge 3 commits into
mainfrom
mb/feat/embed-url-options
Draft

mustafab0 wants to merge 3 commits into
mainfrom
mb/feat/embed-url-options

Conversation

@mustafab0

@mustafab0 mustafab0 commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

What

Two opt-in URL options for an app that shows the Controller in an iframe, and one fix for every page.

  • ?robot=<type> (for example arm): this page uses that robot type. It is saved nowhere, so other Controller pages keep theirs.
  • ?onboarding=off: no first-run message cards and no "Waiting for lidar data." in the 3D view. Driving is still held when nothing can be driven.
  • Record is disabled while nothing is running (no Launcher run and no robot data on the bus), with the title "Nothing to record: launch a blueprint first". A recording under way can still be stopped. The palette's "Start recording" is held the same way. Topics ending in _request (the page's own asks for the robot's model and named locations) don't count as robot data.

Why

The Manipulation app embeds the Controller as ../dim-controller/?robot=arm&onboarding=off. Feedback from a first-time user: the drive keyboard, "Waiting for lidar data." and the "launch a blueprint with a cmd_vel topic" popup don't apply to an arm, and Record started a recording of nothing.

Without the options, nothing changes.

Tested

deno task typecheck, deno task test (368 pass) and nix build .#dimosApp. Live in Desktop with xarm-perception-sim, embedded in the Manipulation app: no onboarding card and no "Waiting for lidar data." while it runs, the point cloud shows. Record is disabled while nothing runs. After a run stops, Record turns disabled once the gateway stops listing that run's topics (about 5 minutes).

robot=<type> makes this page use that robot type without saving it (lv.view.robot is left to the other pages); unknown values are ignored. onboarding=off hides the first-run message cards and the 3D view's "Waiting for lidar data." overlay; the onboarding result still holds driving when nothing can be driven. For the Manipulation app, which embeds the Controller as ../dim-controller/?robot=arm&onboarding=off.
With no Launcher run and no robot data on the bus, the Record button (bar and phone) and the palette's Start recording no longer start an empty recording; the button's title says "Nothing to record: launch a blueprint first". A blueprint run from a terminal still counts, and a recording under way can always be stopped. The "nothing running" test Onboarding used is now core/runs.ts nothingRunning, shared by both.
The Controller asks for the robot's model and named locations on
/render_file_request, /file_request and /named_locations_request even
when nothing runs. Those topics made nothingRunning false, so Record
stayed enabled and the no-blueprint card never showed while idle.
Topics ending in _request are now not counted as robot data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant