Repository navigation
refactor(control): retire shared transport adapters - #5017
Merged
Merged
Conversation
TomCC7
requested review from
Dreamsorcerer,
aclauer,
leshy,
mustafab0,
paul-nechifor and
spomichter
as code owners
November 4, 2026 07:29
Contributor
There was a problem hiding this comment.
go2 replay realtime (arm64)
Details
| Benchmark suite | Current: bc77500 | Previous: 1e8989d | Ratio |
|---|---|---|---|
peak memory |
1765.422 MB |
1755.098 MB |
1.01 |
peak threads |
376 threads |
365 threads |
1.03 |
network (transport) |
2725.017 MB |
2728.417 MB |
1.00 |
disk write |
1.645 MB |
1.602 MB |
1.03 |
instructions |
141.543 G |
137.431 G |
1.03 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
[High impact] The PR changes command and feedback paths for three robot platforms. Fix the MuJoCo halt path before merging so the simulated Go2 stops when coordinator commands disappear. FindingsSummaryReplaces shared transport adapters with direct joint commands for R1Pro, G1, and Go2.
Reviews (2) · Last reviewed commit: "test(r1pro): keep focused driver smoke c..." · Reviewed by Greptile |
…coordinator A robot behind a ConnectionModule with a cmd_vel port had its base told 0 on every axis every tick, so no task could drive it. Now its base axes (<robot>/base/vx, vy, wz) are registered like an adapter base's virtual joints: tasks claim and win them in arbitration, the tick loop routes them to their own per-robot entry so a velocity task on the base never mode-conflicts with a position task on the joints, and ConnectionSource fills each axis with the winner's speed or 0 when idle or stopped. The coordinator's twist_command mapping covers connection robots too, so the same teleop/nav publishers drive an adapter base or a connection base unchanged. Estop semantics are unchanged: commands stop, the connection module's own deadman halts the robot. Arm-only coordinators and legacy adapter stacks are untouched: a robot without a cmd_vel port has no base axes, and adapters never take the new route.
Follow-up verification for the connection base winners: a velocity task or twist drives vx, vy and wz each non-zero through to the robot's cmd_vel port; two velocity tasks on the same base arbitrate by priority and the loser resumes when the winner stops; and a task whose stream goes quiet zeroes every axis, as an adapter base's does.
The velocity-task timeout can be observed by a later tick than the sleep(0.1) boundary on slow or loaded runners (seen on macOS CI), so keep ticking until the zeroed command shows up.
… hold Greptile review on #5016: - P1: OperatorHoldTask discovered axes only in the joint-state snapshot, which never contains a connection robot's base axes (they are commanded speeds, not read positions), so a running velocity task kept driving the base through a hold, including after an e-stop clear. The coordinator now names every connection base axis to the hold (on start and on add_task), and the hold zeroes them like an adapter base's velocity joints. - P2: the base-timeout test slept 0.1s against a 0.2s reading timeout, so a paused runner stopped the command entirely and the zeroed twist never arrived (seen on macOS CI). The test now advances the task clock (perf_counter, the source of state.t_now) past the task timeout by hand and re-reports the base's feedback right before each tick, so only the task command expires. - P2: the routing test drove an arm named mock and a base named go2, never exercising one robot's <robot>/base split and merge. A new test gives one robot joint ports and cmd_vel and asserts both commands leave in the same tick; another covers the route-level mode-conflict guard, which was the patch's only uncovered code. Regressions: the hold zeroes a running base and keeps it after an e-stop clear (connection level), and unit tests cover set_base_axes with and without an e-stop.
The task clock (perf_counter) was already patched, but the connection source stamps feedback receipts and checks their freshness with the real monotonic clock, so a scheduling pause longer than reading_timeout_s between the last report and the tick could still stale the feedback and drop the zeroing command. Patch time.monotonic with its own frozen clock too, and keep a real 0.25s pause between the report and the tick to prove a slow runner cannot stale the feedback: with the monotonic patch removed the strict assertions fail again.
The Go2 blueprints built a full ConnectionConfig at import to copy its contract fields. Main now checks for a robot IP when that config is built, so importing the blueprints failed without ROBOT_IP. go2_joint_connection() gives the coordinator the source, model and joint commands directly.
Solidify MetaBlueprints before reading atoms, give Go2 blueprint parsing a documentation-range robot IP, patch the WebRTC class where go2.connection now imports it, feed odometry to the followers in the benchmark test, check the R1 Pro body axes instead of the planar joints, and wait with wait_until instead of sleeping.
stop_movement did nothing in MuJoCo, so a halt left the simulated robot walking at its last speed. It now sends zero speed.
mustafab0
approved these changes
Nov 21, 2026
mustafab0
enabled stacked auto-merge (squash)
November 21, 2026 21:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Migrate concrete connections to the shared joint/interface contract and retire the two shared transport adapters. Stacked on #5016.
Problem
The old adapters duplicate routing, while rotating native body commands through odometry unnecessarily couples driving to pose age.
Changes
Validation