Repository navigation
[bot] Run the DDS tests in the regular test matrix (superseded by #5330) - #5279
Closed
Dreamsorcerer wants to merge 1 commit into
Closed
Dreamsorcerer wants to merge 1 commit into
Dreamsorcerer wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
go2 replay realtime (arm64)
Details
| Benchmark suite | Current: f62f2e7 | Previous: f3bf594 | Ratio |
|---|---|---|---|
peak memory |
1763.883 MB |
1759.871 MB |
1.00 |
peak threads |
379 threads |
380 threads |
1.00 |
network (transport) |
2728.335 MB |
2728.461 MB |
1.00 |
disk write |
1.66 MB |
1.656 MB |
1.00 |
instructions |
138.772 G |
137.179 G |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #5279 +/- ##
==========================================
- Coverage 84.26% 84.25% -0.01%
==========================================
Files 1903 1905 +2
Lines 187406 187533 +127
Branches 15372 15380 +8
==========================================
+ Hits 157917 158015 +98
- Misses 25405 25433 +28
- Partials 4084 4085 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is from an agent via my MCP server, a human will verify it soon.
Superseded by #5330. With
unitree-sdk2py-dimos1.0.4 released, that PR moves to cyclonedds 11.1 and runs the DDS tests from wheels instead of building 0.10.5 from source. This branch is behind main and conflicts inci.yml, and the connector cannot merge main into it, so the change was rebuilt from current main there. This PR can be closed.Why do we need this?
The DDS transport test is skipped in every CI job, because nothing installs cyclonedds. That is how the Python 3.14 move broke the
ddsandunitree-ddsextras without CI noticing (#5272).What is this feature?
The Ubuntu legs of the
testsjob now install theddsextra, sotest_dds_transport_roundtrip_preserves_qos_and_domainruns on Python 3.10, 3.11 and 3.12 (x86_64) and 3.12 (arm64) instead of being skipped.cyclonedds-devand the/opt/cycloneddslayout the build expects (the same recipe asdocker/python/Dockerfile).uint8fields, which breaks the Unitree SDK messages against 0.10 peers (the robots) untilunitree-sdk2py-dimosis updated.Alternative to #4310, which runs the test in the self-hosted job instead. The two should not both land: #4310 marks the test
self_hosted, which takes it out of this job.How to manually run this
Nothing to run locally. In this PR's
tests (…, ubuntu-…)jobs the DDS transport test is reported as passed rather than skipped.Which issue(s) does this PR close?
None.
Checklist