Skip to content

[bot] Run the DDS tests in the regular test matrix (superseded by #5330) - #5279

Closed
Dreamsorcerer wants to merge 1 commit into
mainfrom
bot-sam/ci/dds-tests
Closed

Dreamsorcerer wants to merge 1 commit into
mainfrom
bot-sam/ci/dds-tests

Conversation

@Dreamsorcerer

@Dreamsorcerer Dreamsorcerer commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

This is from an agent via my MCP server, a human will verify it soon.


Superseded by #5330. With unitree-sdk2py-dimos 1.0.4 released, that PR moves to cyclonedds 11.1 and runs the DDS tests from wheels instead of building 0.10.5 from source. This branch is behind main and conflicts in ci.yml, and the connector cannot merge main into it, so the change was rebuilt from current main there. This PR can be closed.


Why do we need this?

The DDS transport test is skipped in every CI job, because nothing installs cyclonedds. That is how the Python 3.14 move broke the dds and unitree-dds extras without CI noticing (#5272).

What is this feature?

The Ubuntu legs of the tests job now install the dds extra, so test_dds_transport_roundtrip_preserves_qos_and_domain runs on Python 3.10, 3.11 and 3.12 (x86_64) and 3.12 (arm64) instead of being skipped.

  • cyclonedds 0.10.5 has wheels for Python 3.10 only. On 3.11+ and on arm64 it builds from source against the CycloneDDS C library, so the job installs Ubuntu's cyclonedds-dev and the /opt/cyclonedds layout the build expects (the same recipe as docker/python/Dockerfile).
  • The macOS legs are unchanged and keep skipping the test: there is no Homebrew formula for CycloneDDS.
  • cyclonedds stays at 0.10.5 on purpose. 11.x has wheels, but it changes the wire type of uint8 fields, which breaks the Unitree SDK messages against 0.10 peers (the robots) until unitree-sdk2py-dimos is updated.

Alternative to #4310, which runs the test in the self-hosted job instead. The two should not both land: #4310 marks the test self_hosted, which takes it out of this job.

How to manually run this

Nothing to run locally. In this PR's tests (…, ubuntu-…) jobs the DDS transport test is reported as passed rather than skipped.

Which issue(s) does this PR close?

None.

Checklist

  • I have read and approved the CLA.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go2 replay realtime (arm64)

Details
Benchmark suite Current: f62f2e7 Previous: f3bf594 Ratio
peak memory 1763.883 MB 1759.871 MB 1.00
peak threads 379 threads 380 threads 1.00
network (transport) 2728.335 MB 2728.461 MB 1.00
disk write 1.66 MB 1.656 MB 1.00
instructions 138.772 G 137.179 G 1.01

This comment was automatically generated by workflow using github-action-benchmark.

@codecov

codecov Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #5279      +/-   ##
==========================================
- Coverage   84.26%   84.25%   -0.01%     
==========================================
  Files        1903     1905       +2     
  Lines      187406   187533     +127     
  Branches    15372    15380       +8     
==========================================
+ Hits       157917   158015      +98     
- Misses      25405    25433      +28     
- Partials     4084     4085       +1     
Components Coverage Δ
Tests 96.80% <ø> (+0.01%) ⬆️
Flag Coverage Δ
OS-macos-latest 78.64% <ø> (-0.01%) ⬇️
OS-ubuntu-24.04-arm 78.28% <ø> (-0.01%) ⬇️
OS-ubuntu-latest 78.75% <ø> (-0.01%) ⬇️
Py-3.10 78.75% <ø> (+<0.01%) ⬆️
Py-3.11 78.72% <ø> (+<0.01%) ⬆️
Py-3.12 78.74% <ø> (+<0.01%) ⬆️
SelfHosted-Linux 40.73% <ø> (-0.01%) ⬇️
SelfHosted-macOS 40.47% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Dreamsorcerer Dreamsorcerer changed the title [bot] Run the DDS tests in the regular test matrix [bot] Run the DDS tests in the regular test matrix (superseded by #5330) Nov 18, 2026
@Dreamsorcerer
Dreamsorcerer deleted the bot-sam/ci/dds-tests branch November 18, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant