Repository navigation
feat(cloud): allow directory uploads as tar files - #5329
Conversation
There was a problem hiding this comment.
go2 replay realtime (arm64)
Details
| Benchmark suite | Current: 030ee8a | Previous: 1e8989d | Ratio |
|---|---|---|---|
peak memory |
1738.43 MB |
1755.098 MB |
0.99 |
peak threads |
365 threads |
365 threads |
1 |
network (transport) |
2724.122 MB |
2728.417 MB |
1.00 |
disk write |
1.66 MB |
1.602 MB |
1.04 |
instructions |
138.226 G |
137.431 G |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #5329 +/- ##
=======================================
Coverage ? 83.31%
=======================================
Files ? 1963
Lines ? 198265
Branches ? 16569
=======================================
Hits ? 165189
Misses ? 28995
Partials ? 4081
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Review reportComparison base (merge base): Review map (vs.
Validation
|
[Medium impact] The change reaches the cloud data upload workflow for people who explicitly choose a directory. Fix the missing directory contents and staging location before merging. Findings
SummaryDirectory uploads now create a tar archive and send it through the existing file-upload flow.
Reviews (1) · Last reviewed commit: "refactor(cloud): make directory support ..." · Reviewed by Greptile |
Overview
Pass a directory to
dimos data upload PATHto upload it as a tar archive.Problem
Directory uploads currently require creating an archive by hand.
Changes
lz4by default). Ordinary file uploads are unchanged.dimos data pullreturns the.tarwithout unpacking it. Extract it manually withtar -xf ARCHIVE.tar.Validation
96 local tests passed, 4 skipped at
030ee8ab3f. Review report.