Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
go2 replay realtime (arm64)
Details
| Benchmark suite | Current: 74b0c32 | Previous: 7aa6212 | Ratio |
|---|---|---|---|
peak memory |
1745.863 MB |
1746.68 MB |
1.00 |
peak threads |
375 threads |
372 threads |
1.01 |
network (transport) |
2733.864 MB |
2733.75 MB |
1.00 |
disk write |
1.871 MB |
1.664 MB |
1.12 |
instructions |
137.341 G |
137.505 G |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #5411 +/- ##
==========================================
- Coverage 84.92% 84.91% -0.01%
==========================================
Files 1963 1963
Lines 192835 192835
Branches 15711 15711
==========================================
- Hits 163758 163755 -3
- Misses 25212 25214 +2
- Partials 3865 3866 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
aa-MONTS
marked this pull request as ready for review
November 21, 2026 05:23
aa-MONTS
requested review from
Dreamsorcerer,
TomCC7,
aclauer,
jeff-hykin,
leshy,
mustafab0,
paul-nechifor and
spomichter
as code owners
November 21, 2026 05:23
Contributor
[Medium impact] The PR appears safe to merge; no actionable issue was found. SummaryMoves the LangGraph compatibility restriction into the published
aa-MONTS explicitly accepts that another broken release would need a new exclusion. Reviews (1) · Last reviewed commit: "fix(agents): resolve compatible LangGrap..." · Reviewed by Greptile |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exclude known-broken combinations of agent libraries so a successful install doesn’t leave you with an agent that can’t start.
To be reviewed by @paul-nechifor.
Why do we need this?
A library user who keeps the supported LangChain 1.2.3 can install all the documented extras and still get an agent that cannot start. The main wheel resolves LangGraph 1.0.10 with langgraph-prebuilt 1.0.13. The latter imports
ExecutionInfofrom a runtime that lacks it. The checkout’s uv-only override also allows an unlocked install run inside the repository to force prebuilt 1.0.8 alongside newer LangGraph.What is this feature?
The agents extra now excludes prebuilt 1.0.9 through 1.0.13 in wheel metadata. All five published wheels import runtime types missing from LangGraph 1.0.10. A sixth broken release would still be eligible until its dependency metadata is corrected or it is excluded. A blanket cap of
<=1.0.8would prevent installing a working LangChain 1.5.2, whose LangGraph requires prebuilt 1.1 or later.In a fresh library environment at the supported minimum, the fixed wheel selected LangGraph 1.0.10, prebuilt 1.0.8 and LangChain 1.2.3. With unrestricted versions, an external install of either wheel selected 1.2.24, 1.1.3 and 1.5.2 respectively. When uv ran inside the checkout, both revisions selected LangGraph 1.2.22 and LangChain 1.5.0. Main forced prebuilt 1.0.8 and failed to import ToolCallTransformer. The fix selected 1.1.2. Each working combination returned a recorded reply from the Go2 blueprint’s agent. The developer lock retains its relative cutoff and all 562 package versions. Runtime verification used Python 3.12 on macOS arm64, a fixture model and the agent component in isolation.
Live model services and physical robots were outside the checks.
How to manually run this
From a checkout with uv and Python 3.12, build a local wheel and install it from an empty directory. The extra LangChain requirement reproduces the supported minimum. Use a fresh environment for each revision. The build flag skips the optional web UI assets for this Python-only check.
Main raises an import error. The fixed wheel prints
create_agent. Omitting the LangChain pin exercises the current dependency family.Which issue(s) does this PR close?
Fixes DIM-732
Checklist