Repository navigation
Conversation
There was a problem hiding this comment.
go2 replay realtime (arm64)
Details
| Benchmark suite | Current: bb4a83b | Previous: 7aa6212 | Ratio |
|---|---|---|---|
peak memory |
1760.652 MB |
1746.68 MB |
1.01 |
peak threads |
370 threads |
372 threads |
0.99 |
network (transport) |
2736.363 MB |
2733.75 MB |
1.00 |
disk write |
1.953 MB |
1.664 MB |
1.17 |
instructions |
139.009 G |
137.505 G |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #5412 +/- ##
==========================================
- Coverage 84.91% 84.89% -0.03%
==========================================
Files 1962 1963 +1
Lines 192795 192950 +155
Branches 15711 15740 +29
==========================================
+ Hits 163715 163796 +81
- Misses 25223 25291 +68
- Partials 3857 3863 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 12 files with indirect coverage changes 🚀 New features to boost your workflow:
|
[Medium impact] The PR appears safe to merge; no blocking issues remain. SummaryRemoves Playground from the
Reviews (2) · Last reviewed commit: "test(sim): cover offline reuse of pinned..." · Reviewed by Greptile |
|
Want your agent to iterate on Greptile's feedback? Try greploops. |
Load Unitree’s pinned simulation models from dimOS’s own cache instead of relying on a download helper that newer Playground releases removed.
To be reviewed by @paul-nechifor.
Why do we need this?
A fresh install of the
simextra could select Playground 1.x and fail when starting a simulated Unitree robot. DimOS used Playground only to download MuJoCo Menagerie meshes through a private helper that disappeared in 1.x.What is this feature?
The
simextra no longer depends on Playground. Unitree startup and model loading now use the same DimOS Git asset cache and the same Menagerie revision as before. The MuJoCo engine also reads meshes through that model loader. The library install check imports the installed DimOS model loader. To inspect the remaining references, rungit grep -n mujoco_playground -- dimos. The only production hit looks up the optional package location for existing users. The other hit is a CLI startup test.If Playground is installed and its bundled
external_deps/mujoco_menageriecheckout has a detached HEAD at1b86ece576591213e2b666ebf59508454200ca97, DimOS uses it in place without downloading it again. On a fresh install, or when the old checkout points elsewhere, DimOS resolves that revision in its own cache. A cached checkout already at the pin can be reused offline.How to manually run this
From the checkout, in a fresh Python 3.12 environment, install the library extras and check that the model loader imports with Playground absent.
To inspect the chosen checkout, run the following command. The first run needs network access if neither cache contains the pinned revision. Run it again offline to check reuse.
python -c 'from dimos.simulation.mujoco.menagerie import menagerie_path; print(menagerie_path())'On macOS arm64, the fresh install imported the loader with Playground absent. Using a local Git fixture, a second process compiled a MuJoCo mesh from the shared cache after the source went offline. Verification of the final change did not cover a cold download from upstream, reuse of a real installed Playground checkout, or a full Unitree simulation and viewer launch. The earlier Linux x86-64 Go2 launch used the first commit's Playground cap.
Which issue(s) does this PR close?
Fixes DIM-733
Checklist