Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
go2 replay realtime (arm64)
Details
| Benchmark suite | Current: 1b02f17 | Previous: 004b793 | Ratio |
|---|---|---|---|
peak memory |
1791.746 MB |
1788.332 MB |
1.00 |
peak threads |
374 threads |
373 threads |
1.00 |
network (transport) |
2722.417 MB |
2731.926 MB |
1.00 |
disk write |
1.941 MB |
1.891 MB |
1.03 |
instructions |
141.673 G |
142.569 G |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
aa-MONTS
marked this pull request as ready for review
November 21, 2026 05:36
aa-MONTS
requested review from
Dreamsorcerer,
TomCC7,
aclauer,
jeff-hykin,
leshy,
mustafab0,
paul-nechifor and
spomichter
as code owners
November 21, 2026 05:36
Contributor
[Medium impact] The PR appears safe to merge; no new blocking issues were found. SummarySwitches the mapping extra to upstream
Reviews (2) · Last reviewed commit: "test(mapping): collect the GTSAM provide..." · Reviewed by Greptile |
gtsam 4.3.0 declares pytest>=9.0.1 as a runtime dependency, as the fork did, so the pin still needs its override. Without it the lock moved to pytest 9.2.0, whose monkeypatch undo deletes Starlette state attributes and fails the parametrized teleop skill test from its second case on.
The install built a wheel, which needs built web assets and replaces an editable install. A failed install was also hidden by the import check that followed it, so the docs job reported the block as passing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install a usable GTSAM mapping library on Linux x86-64 with Python 3.10 so Go2 replay doesn’t fail after following the install instructions.
To be reviewed by @jeff-hykin.
Why do we need this?
On Linux x86-64 with Python 3.10, installing the Unitree extra leaves out the GTSAM bindings. Go2 replay reads its recording and then the pose-graph mapper exits at
import gtsam.What is this feature?
Use upstream GTSAM for the mapping extra. The lock selects 4.3a1 on Python 3.10 and 4.3.0 on Python 3.11 and 3.12. A fork-only dependency cannot supply the Linux 3.10 wheel, and switching between distributions by platform would leave the same public import backed by different implementations. The mapper passes its existing translation array to
Pose3. The test and lint environments keep the repository’s pytest 8.3.5 pin; switching GTSAM does not upgrade pytest.When upgrading an existing environment, uninstall
gtsam-extendedfirst. The distributions share files undergtsam/; reinstalling the upstream package restores those files if the fork was removed last. The requirements guide includes the commands.How to manually run this
In a clean checkout on Linux x86-64 with CPython 3.10 available, make a fresh environment and install the headless replay dependencies.
Once the blueprint starts, run
dimos topic echo odomin a second shell with the same environment active. The recording should produce changing positions. Stop both commands with Ctrl-C.The provider change produced 117 changing poses on Linux x86-64 with Python 3.10. The rebased proposal was checked against the Linux target’s locked dependencies and with native macOS ARM64 replay. The rebased fix was then installed into a fresh virtual environment on Ubuntu 26.04 x86-64 with Python 3.10 (the commit after it only moves a test file): main failed at
import gtsamand its Go2 replay exited before start-up completed, while this branch imported GTSAM 4.3a1 and the replay published 176 odometry samples at 169 distinct positions in ten seconds. Hardware operation and fork-specific APIs outside dimOS mapping were not verified.Which issue(s) does this PR close?
Fixes DIM-716
Checklist