Skip to content

feat(r1pro): add guarded SysID diagnostics and recording - #5477

Draft
TomCC7 wants to merge 1 commit into
cc/feat/r1pro-mujoco-policyfrom
cc/feat/r1pro-sysid
Draft

TomCC7 wants to merge 1 commit into
cc/feat/r1pro-mujoco-policyfrom
cc/feat/r1pro-sysid

Conversation

@TomCC7

@TomCC7 TomCC7 commented Nov 21, 2026 •

Copy link
Copy Markdown
Member

Why do we need this?

Collect timestamped command and feedback data for R1 Pro system identification. Stack: #5019 → #5476 → #5477. This draft targets #5476 and adds SysID diagnostics and recording on top of the MuJoCo policy layer.

What is this feature?

  • Adds a SysID blueprint with dry-run previews, explicit live opt-in, feedback checks, and abort-to-hold behavior.
  • Adds raw ROS RX/TX diagnostics and documents the typed Zenoh streams to record in MCAP.
  • Run45 ONNX/XML model artifacts remain external and are not required or committed by this PR.

How to manually run this

Use the offline preview in SYSID.md. No robot commissioning has been performed.

Validation

  • Local CPU-only verification at 4372ea068c3651fdb951fff45d7e88960d1dc79e (CUDA_VISIBLE_DEVICES="", R1PRO_SIM_BUNDLE pointing to the external run45 demo bundle): 17 passed, 0 skipped — test_sysid.py (9), test_mujoco_policy.py (3, including CPU ONNX closed loop), and test_all_blueprints_generation.py (5).
  • Both blueprint entries and their module registrations import from the rebased checkout.
  • Earlier broader run (pre-rebase): the planar-preview KeyError: r1pro/base_x also reproduced on R1Pro adapter-free dual grippers on the standard manipulation API #5019; that test was not part of this focused rerun. The earlier offline SysID CLI preview produced 301 JSONL rows.

Checklist

  • I have read and approved the CLA.

@codecov

codecov Bot commented Nov 21, 2026

Copy link
Copy Markdown

⚠️ JUnit XML file not found

The CLI was unable to find any JUnit XML files to upload.
For more help, visit our troubleshooting guide.

@TomCC7
TomCC7 force-pushed the cc/feat/r1pro-sysid branch from 286719a to 4372ea0 Compare November 21, 2026 22:01
@TomCC7
TomCC7 changed the base branch from cc/feat/r1pro-grippers to cc/feat/r1pro-mujoco-policy November 21, 2026 22:01

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant