Skip to content

code refactor - medium/high risk; changelog, badges - #119

Open
bidi47 wants to merge 4 commits into
6.0from
6.0-refactor
Open

bidi47 wants to merge 4 commits into
6.0from
6.0-refactor

Conversation

@bidi47

@bidi47 bidi47 commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

arguments for the dead code removal

  • Nothing ever wrote to $attachments. Email has no attach() or embed(), so the loop in prepareParts() never ran
  • prepareParts() returned the HTML part unchanged and generateBody() returned "text and/or HTML"
  • MailService handles attachments separately and never calls Email

linked with #118

Signed-off-by: bidi <bidi@apidemia.com>
Signed-off-by: bidi <bidi@apidemia.com>
@bidi47 bidi47 changed the title code refactor - medium risk code refactor - medium/high risk Oct 29, 2026
Signed-off-by: bidi <bidi@apidemia.com>
@bidi47 bidi47 changed the title code refactor - medium/high risk code refactor - medium/high risk, changelog Oct 29, 2026
Signed-off-by: bidi <bidi@apidemia.com>
@bidi47 bidi47 changed the title code refactor - medium/high risk, changelog code refactor - medium/high risk; changelog, readme, security files Oct 29, 2026
@bidi47 bidi47 changed the title code refactor - medium/high risk; changelog, readme, security files code refactor - medium/high risk; changelog, badges Oct 29, 2026
@bidi47 bidi47 linked an issue Oct 29, 2026 that may be closed by this pull request
@bidi47
bidi47 requested a review from alexmerlin October 29, 2026 17:00

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TODO upgrade docs

1 participant