Repository navigation
Issue #100: Block symfony/polyfill-php83 <1.30 - #102
SergiuBota1 wants to merge 3 commits into
Conversation
…tions in lowest-deps CI Signed-off-by: bota <sergiubota@rospace.com>
Signed-off-by: bota <sergiubota@rospace.com>
|
@SergiuBota1 Please fix the issues reported by Qodana as well. |
Signed-off-by: bota <sergiubota@rospace.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.0 #102 +/- ##
============================================
- Coverage 96.00% 95.95% -0.05%
+ Complexity 119 117 -2
============================================
Files 17 17
Lines 375 371 -4
============================================
- Hits 360 356 -4
Misses 15 15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| { | ||
| public function __construct( | ||
| private array $payload, | ||
| public array $payload, |
There was a problem hiding this comment.
@SergiuBota1 Based on your experience with Dotkernel Queue, does a message need to change after it was initialized? Did you ever need to add/overwrite keys/values?
If not, then $payload (or rather the Message class itself) should become readonly.
There was a problem hiding this comment.
Actually, we do this inside the handler for the purpose of logging the retry, before using the retry functionality provided by Symfony Messenger we used a custom approach that involved storing the retry count in the payload. If I recall correctly, the goal was to have every failed attempt recorded in the log file, we probably need to rethink this and extract everything we need from the envelope while keeping the payload readonly.
No description provided.