Skip to content

Issue #100: Block symfony/polyfill-php83 <1.30 - #102

Open
SergiuBota1 wants to merge 3 commits into
2.0from
issue-100
Open

SergiuBota1 wants to merge 3 commits into
2.0from
issue-100

Conversation

@SergiuBota1

Copy link
Copy Markdown
Member

No description provided.

…tions in lowest-deps CI

Signed-off-by: bota <sergiubota@rospace.com>
Signed-off-by: bota <sergiubota@rospace.com>
@SergiuBota1 SergiuBota1 linked an issue Oct 28, 2026 that may be closed by this pull request
@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Qodana for PHP

It seems all right 👌

No new problems were found according to the checks applied

☁️ View the detailed Qodana report

Detected 61 dependencies

Third-party software list

This page lists the third-party software dependencies used in project

Dependency Version Licenses
brick/varexporter 0.6.0 MIT
doctrine/collections 3.1.0 MIT
doctrine/dbal 4.5.0 MIT
doctrine/deprecations 1.1.6 MIT
doctrine/event-manager 2.1.1 MIT
doctrine/inflector 2.1.1 MIT
doctrine/instantiator 2.1.0 MIT
doctrine/lexer 3.0.3 MIT
doctrine/orm 3.7.5 MIT
doctrine/persistence 4.2.1 MIT
dotkernel/dot-cli 3.11.1 MIT
dotkernel/dot-dependency-injection 1.4.1 MIT
dotkernel/dot-errorhandler 5.0.0 MIT
dotkernel/dot-log 5.3.1 MIT
fig/http-message-util 1.1.5 MIT
gsteel/dot 1.9.0 MIT
laminas/laminas-cli 1.15.0 BSD-3-Clause
laminas/laminas-component-installer 3.8.0 BSD-3-Clause
laminas/laminas-config-aggregator 1.20.0 BSD-3-Clause
laminas/laminas-diactoros 3.9.0 BSD-3-Clause
laminas/laminas-escaper 2.18.0 BSD-3-Clause
laminas/laminas-httphandlerrunner 2.14.0 BSD-3-Clause
laminas/laminas-servicemanager 4.5.1 BSD-3-Clause
laminas/laminas-stdlib 3.21.0 BSD-3-Clause
laminas/laminas-stratigility 4.3.1 BSD-3-Clause
laminas/laminas-translator 2.0.0 BSD-3-Clause
laminas/laminas-validator 3.19.0 BSD-3-Clause
mezzio/mezzio-router 4.2.0 BSD-3-Clause
mezzio/mezzio-template 3.0.0 BSD-3-Clause
mezzio/mezzio 3.28.1 BSD-3-Clause
netglue/laminas-messenger 2.5.0 MIT
nikic/php-parser v5.9.0 BSD-3-Clause
psr/cache 3.0.0 MIT
psr/clock 1.0.0 MIT
psr/container 2.0.2 MIT
psr/event-dispatcher 1.0.0 MIT
psr/http-client 1.0.3 MIT
psr/http-factory 1.1.0 MIT
psr/http-message 2.0 MIT
psr/http-server-handler 1.0.2 MIT
psr/http-server-middleware 1.0.2 MIT
psr/log 3.0.2 MIT
symfony/clock v8.1.9 MIT
symfony/console v8.1.9 MIT
symfony/deprecation-contracts v3.7.1 MIT
symfony/event-dispatcher-contracts v3.7.1 MIT
symfony/event-dispatcher v8.1.5 MIT
symfony/messenger v8.1.9 MIT
symfony/polyfill-ctype v1.37.0 MIT
symfony/polyfill-deepclone v1.43.2 MIT
symfony/polyfill-intl-grapheme v1.43.3 MIT
symfony/polyfill-intl-normalizer v1.43.0 MIT
symfony/polyfill-mbstring v1.43.3 MIT
symfony/polyfill-php85 v1.43.0 MIT
symfony/polyfill-php86 v1.43.0 MIT
symfony/redis-messenger v8.1.9 MIT
symfony/service-contracts v3.7.3 MIT
symfony/string v8.1.9 MIT
symfony/var-exporter v8.1.9 MIT
webimpress/safe-writer 2.2.0 BSD-2-Clause
webmozart/assert 2.5.0 MIT
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@alexmerlin

Copy link
Copy Markdown
Member

@SergiuBota1 Please fix the issues reported by Qodana as well.

Signed-off-by: bota <sergiubota@rospace.com>
@codecov

codecov Bot commented Oct 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.95%. Comparing base (c2405ee) to head (c3c309e).

Additional details and impacted files
@@             Coverage Diff              @@
##                2.0     #102      +/-   ##
============================================
- Coverage     96.00%   95.95%   -0.05%     
+ Complexity      119      117       -2     
============================================
  Files            17       17              
  Lines           375      371       -4     
============================================
- Hits            360      356       -4     
  Misses           15       15              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

{
public function __construct(
private array $payload,
public array $payload,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SergiuBota1 Based on your experience with Dotkernel Queue, does a message need to change after it was initialized? Did you ever need to add/overwrite keys/values?

If not, then $payload (or rather the Message class itself) should become readonly.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, we do this inside the handler for the purpose of logging the retry, before using the retry functionality provided by Symfony Messenger we used a custom approach that involved storing the retry count in the payload. If I recall correctly, the goal was to have every failed attempt recorded in the log file, we probably need to rethink this and extract everything we need from the envelope while keeping the payload readonly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix small errors

2 participants