Repository navigation
Fix legacy serializer and deserializer warnings to be logged once - #3185
Merged
Merged
Conversation
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
KafkaProducer._serializeandFetcher.PartitionRecords._deserialize, theexcept TypeErrorfallback declaresglobal _LOGGED_SERIALIZE_WARNING/global _LOGGED_DESERIALIZE_WARNINGand checks the module-level flag, but assigns toLOGGED_SERIALIZE_WARNING = True/LOGGED_DESERIALIZE_WARNING = True(missing the leading underscore).Because that creates an unused local variable instead of updating the module-level flag, the
DeprecationWarningis re-evaluated and emitted on every serialized/deserialized record when using a legacy 2-argumentSerializerorDeserializersubclass.Changes
_LOGGED_SERIALIZE_WARNINGinkafka/producer/kafka.pyand_LOGGED_DESERIALIZE_WARNINGinkafka/consumer/fetcher.py.test/producer/test_producer.pyandtest/consumer/test_fetcher.pyverifying the warning is emitted once across multiple records.