Repository navigation
Declare safe workflow entry validation for replacement routing - #176
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Part of durable-workflow/.github#221 and the coordinated Server#518 correction. A replacement definition must not be routed by default to an older worker that can fail the business run while binding its original input.
Change
The corrected high-level Worker advertises the additive
workflow_entry_arguments_validationcapability. Server's replacement-routing correction requires this explicit implementation declaration before changed-fingerprint fallback. Matching definitions and the explicit pinning opt-out retain their contracts. The declaration does not change a protocol floor, minimum supported Server, task authority, workflow input/history/deadlines or business-error semantics. It is not inferred from the SDK version; raw registration callers remain responsible for their own declarations.This PR adds only the Worker declaration and the existing actual registration assertion. It does not change package/dependency versions, entry-validation implementation or published artifacts. Normal exact-head CI and coordinated Server/SDK published acceptance remain required before release or closure of #221. Current published Server 2.9.8 still lacks the structured entry-replay fence; that observed gap is retained at .github#221 comment6293576709.
Local component checks: PHP worker-authoring and entry-binding selection 28 tests / 80 assertions PASS; Python worker/entry selection 260 PASS / 2 explicit skips. These are independent repository selections, not additive whole-product or installed artifact acceptance.