Repository navigation
[patch] Fix YearMonthPicker focus - #2588
Open
PelayoFelgueroso wants to merge 2 commits into
Open
PelayoFelgueroso wants to merge 2 commits into
PelayoFelgueroso wants to merge 2 commits into
Conversation
Jialecl
reviewed
Oct 27, 2026
| export const YearMonthPicker = ({ isYearFirst, selectedDate, today, onYearMonthComplete }: YearMonthPickerProps) => { | ||
| const [selectedYear, setSelectedYear] = useState<number | null>(selectedDate?.get("year") || null); | ||
| const [selectedMonth, setSelectedMonth] = useState<number | null>(selectedDate?.get("month") || null); | ||
| const dateToUse = selectedDate?.isValid() ? selectedDate : today; |
Collaborator
There was a problem hiding this comment.
Instead of dateToUse I think it's better to call it defaultFocusedDate or something that describes better what is this used for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
(Check off all the items before submitting)
/libdirectory./websiteas needed.Purpose
When there is no selectedDate the YearMonthPicker should focus current month and year and keep it visible when opening the YearMonthPicker