Repository navigation
ci: add pull request validate workflow - #2
Merged
Merged
Conversation
petter
added a commit
that referenced
this pull request
Oct 26, 2026
* ci: add pull request validate workflow * ci: run validate on Temurin 25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
These repositories had no GitHub Actions check on pull requests. The .NET and Java Travis files are not a required github.com status. A broken build can merge.
This job compiles the committed tree. It does not run
generate.sh.Scope
.github/workflows/validate.yml.NET restores and builds the single
EBay.*/EBay.*.csproj. PHP runscomposer analyse, thencomposer testonly whencomposer.jsondeclares atestscript. Java runs./gradlew build --no-daemon.Tradeoffs
A family allowlist would drift when GraphQL tests appear. The job reads the repository instead.
Blast Radius
Maintainers see a
validatecheck on every pull request. The job usescontents: readand no secrets. Makingvalidaterequired is a separate ruleset step after the check has reported once.Verification
The workflow YAML parses. The same bytes landed in all 27 clones. Local
dotnet buildsucceeded on listing-metadata, which has no.slnx. Localcomposer analysesucceeded on analytics-and-reporting. Local./gradlew buildsucceeded on analytics-and-reporting. The PHP test gate matchescomposer.json. account-management declarestest. analytics-and-reporting does not.