Repository navigation
fix: reapply pending patch deltas after rollback - #6
Open
manuelmeister wants to merge 2 commits into
Open
manuelmeister wants to merge 2 commits into
manuelmeister wants to merge 2 commits into
Conversation
Apply deltas to confirmed data for 204 responses and preserve server changes. Keep recomputed optimistic values frozen and relation references intact.
Normalize patch deltas using visible relations with confirmed references as fallback. Cover chained relinks with wrapper and URI inputs for 200 and 204 responses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overlapping nested PATCHes can retain values from a failed earlier mutation. A later 204 response can also restore those values or overwrite changes confirmed by the server.
Store a normalized merge-patch delta per mutation and reapply remaining deltas to confirmed data for both optimistic state and 204 commits. Normalize relations using visible references with confirmed references as fallback, so chained relinks remain callable across optimistic and server-side clears. Keep recomputed optimistic values frozen and apply object patches to non-object values according to merge-patch semantics.
Validation: 373 tests pass, including regressions for 200/204 responses, server-adjusted values, optimistic and non-optimistic calls, nested null deletions, arrays, chained relation updates with wrapper and URI inputs, and read-only state. Typecheck, lint, build, publint, and are-the-types-wrong pass.