[ravnskjaer]

The "still initializing" timer and the initialization job could both create the contents of the same compare editor input. One of the two content trees stayed alive when the editor switched to another input, and its viewer later diffed against the disposed input.

Fixes #123

[Copilot]

🟡 Changes recommended

The timing-sensitive fix lacks a deterministic regression test covering the reported race.

1 open finding

• Add regression test for re-entrant CompareEditorInput opening · New

What changed in this PR

Prevents duplicate compare content trees and the resulting DocumentMerger NPE during asynchronous initialization.

Changes:

• Detects re-entrant control creation.
• Skips duplicate content creation while a control is already being built.

File	Description
CompareEditor.java	Guards the initialization callback against duplicate compare controls.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[github-actions]

Test Results

    54 files  ±0      54 suites  ±0   37m 32s ⏱️ + 1m 9s
 4 911 tests +2   4 889 ✅ +2   22 💤 ±0  0 ❌ ±0 
12 624 runs  +6  12 470 ✅ +6  154 💤 ±0  0 ❌ ±0 

Results for commit 8260564. ± Comparison against base commit 1b7b555.

♻️ This comment has been updated with latest results.

[ravnskjaer]

@iloveeclipse I’ve added the regression test Copilot asked for (CompareEditorOpenRaceTest). The GitHub workflows are awaiting approval, and the Jenkins build timed out for this PR too. Could you approve the workflows and retrigger Jenkins?

[ravnskjaer]

Thanks for retriggering, @iloveeclipse, all checks are green now and the Copilot finding is addressed with the new regression test. Could you take a look and merge if it looks good to you?

[ravnskjaer]

@iloveeclipse sorry to bother you again - if you don't have the time, can you maybe direct me to someone else who can review it?

[Copilot]

🟡 Changes recommended

The new guard discards cancellation during content creation, leaving the canceled editor open.

1 open issue

• Preserve cancellation during in-progress content creation · New

1 resolved since last review

• Add regression test for re-entrant CompareEditorInput opening

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

No active review issues were identified for the change preventing duplicate compare-editor content creation during re-entrant initialization.

No open issues 🎉

1 resolved since last review

• Preserve cancellation during in-progress content creation

_{Review effort: Balanced}