Repository navigation
Size the editor before unified diff pixel assertions - #3047
Merged
tobiasmelcher merged 1 commit intoOct 28, 2026
Merged
tobiasmelcher merged 1 commit into
tobiasmelcher merged 1 commit into
Conversation
The test workbench may leave the editor with a zero-sized client area. Set an explicit widget size while rendering the delimiter assertions and restore the previous size afterward. Fixes eclipse-platform#3045
Contributor
Contributor
Author
|
Let us see if this change fixes the i-build run. Please let me know if you have some doubts and if this change needs to be reverted. |
tobiasmelcher
merged commit Oct 28, 2026
67f278c
into
eclipse-platform:master
24 of 26 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The central test workbench can leave the editor with a zero-sized client area, causing both delimiter rendering tests to fail when creating their off-screen image. Give the widget an explicit size during the pixel assertion and restore its original size afterward.
Reproduced both reported exceptions with a zero-sized editor. With the fix, all 46
UnifiedDiffManagerTesttests pass both with a zero-sized editor and with the normal editor layout.Fixes #3045