Repository navigation
Stamp the Windows host with the long product name - #25
Merged
Merged
Conversation
Shell_NotifyIcon attributes the toast to the host process, which previously only received an icon. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Shell_NotifyIcon), and host-first packaging was only embedding an icon into that executable.FileDescriptionandProductNameset toname_long(falling back toname). Beam binaries keep the short name and description.Test plan
mix test test/windows_version_info_test.exsDiode Collabrather than the short description).Made with Cursor
Note
Low Risk
Packaging-only PE metadata changes for Windows host-first layout; no runtime auth or data paths affected.
Reviewed by Cursor Bugbot for commit bc9f476. Configure here.