Skip to content

Stamp the Windows host with the long product name - #25

Merged
dominicletz merged 1 commit into
mainfrom
windows/host-toast-name
Nov 1, 2026
Merged

dominicletz merged 1 commit into
mainfrom
windows/host-toast-name

Conversation

@dominicletz

@dominicletz dominicletz commented Nov 1, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Windows toasts are attributed to the host process (Shell_NotifyIcon), and host-first packaging was only embedding an icon into that executable.
  • Stamp the host with FileDescription and ProductName set to name_long (falling back to name). Beam binaries keep the short name and description.

Test plan

  • mix test test/windows_version_info_test.exs
  • Build a host-first Windows package and confirm the host executable's FileDescription is the long product name (for Diode Collab, Diode Collab rather than the short description).

Made with Cursor


Note

Low Risk
Packaging-only PE metadata changes for Windows host-first layout; no runtime auth or data paths affected.

Reviewed by Cursor Bugbot for commit bc9f476. Configure here.

Shell_NotifyIcon attributes the toast to the host process, which previously only received an icon.

Co-authored-by: Cursor <cursoragent@cursor.com>
@dominicletz
dominicletz merged commit b4a60f5 into main Nov 1, 2026
1 of 3 checks passed
@dominicletz
dominicletz deleted the windows/host-toast-name branch November 1, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants