Repository navigation
ci: run tests on OTP 27 so hackney compiles - #26
Merged
Merged
Conversation
httpoison 3 pulls hackney 4, whose quic dependency refuses OTP 24. Move the macOS workflow to OTP 27.3.4.19 and Elixir 1.18.6, and rewrite windows_file_version/1 as a case so mix credo still passes. Co-authored-by: dominic.letz <dominic.letz@berlin.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macOS workflow on
mainfails inmix deps.getwhile compiling:quic:httpoison ~> 3.0(the Hackney CVE bump) resolves to hackney 4.9.1, which depends onquic. That package will not build on the workflow's OTP 24.3.4.15. The same failure has been onmainsince the Hackney bump.This moves the workflow to OTP 27.3.4.19 and Elixir 1.18.6 (
-otp-27), which is what current hackney documents and what compilesquichere.windows_file_version/1is rewritten as acasesomix credodoes not fail on the single-clausewith.Verified locally on OTP 27 / Elixir 1.18.6:
mix format --check-formatted,mix credo, andmix test --exclude macos(6 tests, 0 failures). The macOS keychain tests still need the GitHub runner.Note
Low Risk
CI toolchain bump plus a behavior-preserving style refactor in Windows packaging metadata; no auth or runtime logic changes.
Reviewed by Cursor Bugbot for commit eeaf3a7. Configure here.