Repository navigation
Quote Windows beam arguments - #17
Merged
Merged
Conversation
cmd.exe splits an unquoted ddrive:// link on &.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Bugbot Autofix is ON, but it could not run because on-demand usage is turned off. To enable Bugbot Autofix, turn on on-demand usage and set a spend limit in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5defd64. Configure here.
| for (auto& a : config_.beam_args) cmd << ' ' << a; | ||
| for (auto& a : config_.forwarded_argv) cmd << ' ' << a; | ||
| for (auto& a : config_.beam_args) cmd << ' ' << quote_cmd_arg(a); | ||
| for (auto& a : config_.forwarded_argv) cmd << ' ' << quote_cmd_arg(a); |
There was a problem hiding this comment.
Quoted args break cmd.exe launch
High Severity
Quoting each beam_args and forwarded_argv value after cmd.exe /c plus a quoted script puts more than two quotes on the line. cmd.exe then strips the first and last quote, which garbles the batch path and leaves & in a forwarded URL outside quotes.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 5defd64. Configure here.
cmd.exe /c drops quotes when start and a protocol URL are both quoted.
A percent sign in the temp cmd file is expanded, and the link would stay on disk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
beam_argsandforwarded_argvvalue on the Windowscmd.exe /cline so addrive://query that contains&stays one argument.Test plan
ddrive://chat/abc?message=hello&thread_root=rootand confirm the beam process receives the full URL.Made with Cursor
Note
Low Risk
Narrow change to how the host formats the beam child-process command line; improves correctness for special characters without touching auth or RPC.
Reviewed by Cursor Bugbot for commit 5defd64. Configure here.