Repository navigation
Stop tray icon updates from replaying the last balloon - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NOTIFYICONDATAsoNIF_INFOis not left on the stored tray icon.notification.closewithout storing that flag.Test plan
notification.closeand confirm the balloon goes away.notification.showstill displays one new balloon.Note
Low Risk
Localized Windows tray/notification handling with no auth or data-path changes; behavior should be strictly improved for icon updates and dismiss.
Overview
Fixes Windows tray behavior where icon updates re-displayed the last balloon because
NIF_INFOwas left on the storedNOTIFYICONDATAW.update_tray_iconnow always applies icon-only flags (NIF_MESSAGE | NIF_ICON | NIF_TIP) beforeNIM_MODIFY. Show and close use a copy oftray.nidfor balloonShell_NotifyIconWcalls so the persisted tray entry never keeps balloon state.Adds a real
notification_closeimplementation (clearszInfo/ title viaNIF_INFOon a copy) and wiresnotification.closein dispatch to it instead of a no-op.Reviewed by Cursor Bugbot for commit bdf693f. Configure here.