Repository navigation
Avoid per-byte binary construction and backtracking in Plug.Conn.Utils.token/1 - #1335
Merged
Merged
Conversation
…s.token/1 - Track byte length and return the original binary directly (or slice via binary_part/3 when trailing whitespace is present) instead of appending byte-by-byte into a writable binary for unquoted tokens. - Initialize the binary match context in do_token/2 so unquoted_token/3 and quoted_token/2 resume the match context without per-iteration header checks. - Fold opening quote handling (len == 0) and empty binary rejection (len != 0) into unquoted_token/3 to avoid upfront empty-binary checks and first-byte backtracking. - Split multi-byte escape and CRLF patterns (<<?\\, rest::binary>> and <<?\r, rest::binary>>) and move <<>> base clauses last so the compiler does not emit per-byte bs_get_position/bs_set_position instructions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisted-by: Antigravity CLI:Gemini 4 Argon
Faster and uses less memory.
Bench:
Results: