Repository navigation
Security lows: credentials stay on their origin across redirects; MCP loopback Host/Origin checks, --auth-token-file (2.13.18) - #82
Merged
Conversation
…opback Host/Origin checks and --auth-token-file (MCP) - 2.13.18 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rlopen still applies embeddedci_mcp.cli_login uses embeddedci._http when the SDK has it (2.13.18), plain urllib with an older SDK. _http.urlopen calls a replaced urllib.request.urlopen, so tests that fake it keep working and never reach the network. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the 2026-11-14 security review (findings 12 and 13):
embeddedci._http.urlopen, whose redirect handler drops Authorization, X-Benchpod-Lease and cookies when the redirect changes host, port or scheme. Tests that patchedurllib.request.urlopennow patchembeddedci._http.urlopen.--auth-token-file, and the help says a command-line token shows inps. README updated.🤖 Generated with Claude Code