Repository navigation
feat(server): meta.instanceName, the name a node navigates as - #95
Merged
Merged
Conversation
A drill-down names its crumb, and the hierarchy outline matches its row, by the node's instance name, which has always been its label. A producer whose node is drawn under one name and navigates under another had no way to say so: a clause of document B drawn at the edge of document A drills into B, and the crumb then said the clause's title, and the outline found no row for it. `meta.instanceName`, a non-empty string, becomes `wf:entityInstanceName`, trimmed. The label and the entity name that rename and lookups use stay as they were; anything else on the key is ignored. Platform-neutral: the key says nothing about what a node is, only what it navigates as. Claude-Session: https://claude.ai/code/session_012yAjXyWw6JyWsXvHG3cG9c
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A drill-down names its crumb, and the hierarchy outline matches its row, by the node's instance name, which has always been the node's label. A producer whose node is drawn under one name and navigates under another had no way to say so. The case that found it: the NDF diagram draws a clause of document B at the edge of document A, external, drilling into B; the crumb then said the clause's title and the outline found no row for it.
meta.instanceName(a non-empty string) becomeswf:entityInstanceName, trimmed. Nothing else moves: the label, and the entity name that rename and lookups use, stay as they were. Any other value on the key is ignored.instance-name.test.ts(3 tests); CHANGELOG entry.Plan item N9 of the ndf-ide plan. Independent of #90–#94.
Test plan
npm run typecheck,npm run check:neutralityhttps://claude.ai/code/session_012yAjXyWw6JyWsXvHG3cG9c