Repository navigation
Conversation
ale18V
force-pushed
the
feat/webapp-task-creation-aggregator-params
branch
2 times, most recently
from
November 12, 2026 16:22
dfb1d44 to
542bb01
Compare
ale18V
force-pushed
the
feat/webapp-task-creation-aggregator-params
branch
from
November 12, 2026 17:14
542bb01 to
9e85bd0
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
This PR updates the webapp task creation form to support the unified aggregator configuration architecture.
Previously, the task creation UI bound to legacy fields like `trainingInformation.maxShareValue` and `privacy.byzantineFaultTolerance`.
This change binds aggregator parameters to `trainingInformation.aggregationParams`, adds support for FedProx in the UI, and validates the task using `aggregationConfigSchema`.
Obsolete form fields for BFT under privacy are removed, ensuring created tasks conform strictly to the modern task schema.
Technical plan
The technical plan aligns the webapp form with the core aggregator configuration schema.
Form fields for Byzantine, Secure, and FedProx aggregators bind directly to properties of `aggregationParams`.
The local form validation schema adopts `aggregationConfigSchema` directly, simplifying the validation pipeline.
End-to-end Cypress tests verify task submission and deserialization with custom aggregation parameters.
Deviations from plan
None.
Todo
None.