Repository navigation
bump Mocha to version 12.0.3 - #295
Open
rafapaezbas wants to merge 1 commit into
Open
rafapaezbas wants to merge 1 commit into
rafapaezbas wants to merge 1 commit into
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
|
You can fix the CI on older Node versions by specifying older versions of mocha as appropriate in compression/.github/workflows/ci.yml Lines 128 to 130 in 0f97074 I think the versions from expressjs/serve-index#171 should be fine ( |
krzysdz
added
dependencies
|
Are you going to be able to make the suggested corrections so the CI passes? |
|
Same problem from the same submitter as in jshttp/on-finished#103 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nodejs/citgm#1171 (comment)