Repository navigation
Conversation
Turn the placeholder Scope field on the key form into a real choice. Rider access sets the key's profile, which limits it to rider routes. Show the choice on the key's overview.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Turns the placeholder Scope field from #55 into a real choice between Full access and Rider access. Rider access sets the key's
profilefrom fleetbase/core-api#329, which limits the key to rider routes. The key's overview shows which one it has.Full access sends no profile, so nothing changes for existing keys.
Merge order
This is based on
feature/developers-redesign, so it should merge after #55. It also needs fleetbase/core-api#329 merged, otherwise the API ignores the field.Testing
Not run: I didn't install dependencies, so neither the Ember tests (including the new unit test) nor the form have been run, and I haven't seen it in a browser. CI on this PR is the first run.