Repository navigation
Prevent PHPStan reporting unknown variable passed to StructureElement - #2704
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #2704 +/- ##
============================================
+ Coverage 89.86% 90.10% +0.24%
- Complexity 337 29571 +29234
============================================
Files 2232 2220 -12
Lines 86413 85881 -532
============================================
- Hits 77658 77387 -271
+ Misses 8755 8494 -261 🚀 New features to boost your workflow:
|
stloyd
enabled auto-merge (squash)
October 23, 2026 13:51
Member
|
hmm now I need to dig a bit deeper and try to understand why Mago missed it to not introduce some conflict 🤔 Looks good at first glance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this PHPStan loses information about second field on
StructureElementwhen passed with it and reports:Change Log
Added
Fixed
Changed
Removed
Deprecated
Security