Repository navigation
Conversation
Three tests asserted that the timer due date is within 100 ms of a timestamp taken before the process start, which fails on a loaded machine. Allow 5 seconds. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Author
|
@dbmalkovsky @filiphr @tijsrademakers @jbarrez - could you please review this small test change? Three tests in |
316022
approved these changes
Oct 30, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three tests in
BoundaryTimerEventTest(includingtestRescheduleRepeatBoundaryTimer) assert that the timer due date is within 100 ms of a timestamp taken before the process is started. That only holds when process start-up is very fast; it failed once for me on a loaded machine (isLessThan(100)) and passed on rerun. The tolerance is now 5 seconds. The tests still check that the timer is due about one hour out.This is separate from the daylight saving test failures, which are handled in #4316.
BoundaryTimerEventTestpasses (25 tests).