Repository navigation
Feature/matrix wide scaling - #351
Conversation
|
example code in SC to see it work and test the dims are right (3x2 is perfect for debugging :) ) |
|
My first thought for the arg name was "by column" (or byCol or whatever is appropriate), which was also one of your suggestions, so there's some resonance there. |
|
PA explained it to me. It's been a while since I've used FluCoMa closely so I needed the crash course. It all makes sense, and I think |
|
now with the right name, and a fork in 'normalize' for @weefuzzy to review and a max patch to make it simple: |
|
My two in-an-ideal-world comments would be
But seeing as I don't have current time / bandwidth to think properly about the added ramifications of the first or come up with something more elegant for the second, I say have at it. |
|
@weefuzzy axis 0 for all, axis 1 and 2 for either, is easy enough for me to implement (and we can refactor the fork eventually) This also has the advantage of allowing for eventual other dimensions (aka time in dataseries). |
|
Well, But, I think there's possible non-obvious side-effects on other bits of the code for those objects that would need be thought about. Hence, if you just want to solve the problem in front of you quickly, do as you were. |
|
ok and HCI-devil-advocate here: if we want to merge now, I can do axis -1 and 0 and leave it at that, and then on the desiderata list, we put 1 and 2 later. a bit like the MFCC @startcoeff which might, one day, get something else than 0 and 1 🤣 the advantage of @axis is that we have that in other objects, and -1 for all is good as we are 0 counting everywhere - so changing that little interface convention now prevent a future breaking change? |
|
I like the numpy-esque |
|
and I've checked (https://numpy.org/doc/2.2/reference/generated/numpy.mean.html), |
|
One thought I had re: |
|
yeah I got squishy during my post-coding thinking about it 🤣 indeed axis with -1 and 0 is a good future proof way I think |
Mostly for 2D drawing, we need matrix-wide, not column-wise, data processing to preserve the original shape and the relevance of diagonal distances. This is done for the 3 transformers.
At the moment, there are 3 questions for @weefuzzy @jamesb93 and @tedmoore :
Thanks!