Skip to content

add optimise as option in transform to match other flucoma behaviour - #357

Merged
tremblap merged 3 commits into
flucoma:mainfrom
tremblap:fix/add-parameter-to-harmonise-expectation
Nov 13, 2026
Merged

tremblap merged 3 commits into
flucoma:mainfrom
tremblap:fix/add-parameter-to-harmonise-expectation

Conversation

@tremblap

Copy link
Copy Markdown
Member

this adds a flag to transform to harmonise the behaviour flucoma style (transform and fittransform yielding the same results) while keeping the canonical option of SGD refinement if the user wants it.

TODO: document and SC-class change if approved

@tremblap
tremblap requested a review from weefuzzy November 11, 2026 15:12
@tremblap

Copy link
Copy Markdown
Member Author

actually maybe the best is to stop returning the embeddings with fittransform. at the moment this is our only object that has a different result with fit -> transform vs fittransform. so what we should probably do is to return the embeddings with fit, or getXXX like (s)kmeans, and run fittransform as fit then transform... in all cases, a UX discussion is needed

@tremblap

Copy link
Copy Markdown
Member Author

ok, overnight wisdom makes for another proposal: we do not touch fittransform, as it gives us the embeddings, but we do add this optimize bool to transform, and document the fit->tranform ISNOT fittransform in the reference. for most usecase, fit then transform with the switch off is the flucoma behaviour, and fittransform returns the embeddings.


MessageResult<void> transform(InputDataSetClientRef sourceClient,
DataSetClientRef destClient)
DataSetClientRef destClient, bool optimize = false)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No benefit in having a default value here (and I don't generally like them), and could rename like algorithm

@tremblap tremblap left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I am resolving comments, but please give me your opinion on the general discussion with the 3 ideas on what to do with fittransform not being fit+transform

tremblap and others added 2 commits November 12, 2026 16:05
@weefuzzy

Copy link
Copy Markdown
Member

but please give me your opinion on the general discussion with the 3 ideas on what to do with fittransform not being fit+transform

I thought leaving fitTransform alone and only modifying the behaviour of transform was what you meant in the first place, so I'm in agreement.

@tremblap
tremblap merged commit deb7f73 into flucoma:main Nov 13, 2026
3 checks passed
@tremblap
tremblap deleted the fix/add-parameter-to-harmonise-expectation branch November 14, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants