Repository navigation
Conversation
The name used to be fixed parameter 0 of every shared client, and the shared instance adaptor keyed its lookup tables on it, so it could not change after construction. The adaptor now owns the name: ParamAliasAdaptor gains name(), setName() (create-or-join, formerly done in setFixedParameterValues) and rename(), which re-keys both lookup tables while leaving the shared client and its parameters untouched. The name parameter and kName are removed from all shared clients, so remaining parameter indices shift down by one. Clients that print their name inherit the new NamedObject mixin, which the adaptor keeps up to date across renames. Host wrappers need to pass the name through setName() and read it with name() instead of using parameter 0. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J2M1cHdyiJWcPaKy2FRnMe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The name used to be fixed parameter 0 of every shared client, and the shared instance adaptor keyed its lookup tables on it, so it could not change after construction.
The adaptor now owns the name: ParamAliasAdaptor gains name(), setName() (create-or-join, formerly done in setFixedParameterValues) and rename(), which re-keys both lookup tables while leaving the shared client and its parameters untouched. The name parameter and kName are removed from all shared clients, so remaining parameter indices shift down by one.
Clients that print their name inherit the new NamedObject mixin, which the adaptor keeps up to date across renames.
Host wrappers need to pass the name through setName() and read it with name() instead of using parameter 0.
Claude-Session: https://claude.ai/code/session_01J2M1cHdyiJWcPaKy2FRnMe