Repository navigation
Upgrade flutter candidate and DCM version - #10048
kenzieschmoll wants to merge 7 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request cleans up redundant argument values across several DevTools packages. Specifically, it simplifies CrossAxisAlignment.values.toList(growable: true) to toList(), replaces Expanded(child: SizedBox()) with Spacer(), and updates numerous Completer.complete(null) calls to complete(). It also updates the changelog for devtools_app_shared and updates package dependencies in pubspec.lock. I have no feedback to provide.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request cleans up redundant null arguments in Completer.complete() calls, replaces an empty Expanded box with Spacer, and introduces custom SIMD formatting in variable_factory.dart to ensure consistent display representation across VM and web platforms. Feedback suggests using lane.toUnsigned(32) instead of bitwise AND to guarantee correct unsigned 32-bit hex formatting on the web, and adjusting the CHANGELOG entry to use past tense and end with a period.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…ory.dart Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This branch has not been deployed
2 participants
Upgrade flutter version and DCM version and fix associated lints and warnings.