Repository navigation
Fix ClearFlag indexing and flag-range diagnostics - #929
Open
jacobyen-2001 wants to merge 1 commit into
Open
jacobyen-2001 wants to merge 1 commit into
jacobyen-2001 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClearFlag compiled the user-facing flag number directly, although flag operations store zero-based bit indices. For example, ClearFlag 5 cleared flag 6. Compile x - 1, matching SetFlag and the preprocessor flag operations.
The out-of-range diagnostics in both SetFlag and ClearFlag also omitted the flag-number argument to MesPrint. Supply it so the two format placeholders receive valid arguments.
Validation: all three new regressions fail before the change and pass afterward in both FORM and TFORM. They check that clearing several flags preserves their neighbors and that invalid flag diagnostics report the supplied number. The complete standard suites ran 563 tests each, with zero failures/errors (FORM: 9 platform omissions; TFORM: 3 existing pendings and 4 omissions). Built on macOS arm64 with GMP and MPFR enabled, without FLINT.
Fixes #855.
Implemented and tested by OpenAI Codex at the account owner's request.