Repository navigation
Conversation
📲 Install BuildsAndroid
|
adinauer
marked this pull request as ready for review
October 30, 2026 09:34
adinauer
requested review from
0xadam-brown,
markushi,
romtsn and
runningcode
as code owners
October 30, 2026 09:34
runningcode
approved these changes
Oct 30, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Remove
@ApiStatus.ExperimentalfromSentryClient.captureMetric(...).The corresponding
ISentryClientmethod and high-level Application Metrics API are already stable. Batched transport and processor plumbing remain internal. This changes API status only; metric capture behavior remains unchanged.💡 Motivation and Context
The Application Metrics API already provides stable counters, gauges, distributions, units, attributes, scope association, and
beforeSendMetric. The annotation on the concrete client implementation is inconsistent with the stable interface and public API.High-volume buffering and accumulation improvements tracked in #6150 and #6151 can be implemented behind the existing capture API.
Refs #6408
💚 How did you test it?
Ran:
Both commands completed successfully, and API generation produced no API dump changes.
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Improve high-volume buffering and metric accumulation separately without changing the public metrics API.