Repository navigation
Conversation
Apply resolver-filtered query parameters and fragments to Ktor client spans while keeping span descriptions free of URL details. Respect URL query collection deny lists and off mode. Fixes #5984 Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
📲 Install BuildsAndroid
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Apply resolver-filtered URL query parameters and fragments to Ktor HTTP client spans as
http.queryandhttp.fragmentdata. Span descriptions continue to exclude query parameters and fragments.💡 Motivation and Context
Ktor client spans currently omit URL detail data that other HTTP client integrations provide. This adds the data through the shared
UrlUtilspath so URL query deny lists and off mode are respected.The behavior was intentionally deferred from #5983 to the 9.0 major release because legacy, unconfigured data-collection settings preserve query values.
resolves: #5984
refs: JAVA-701
💚 How did you test it?
./gradlew :sentry-ktor-client:check./gradlew spotlessApply apiDump📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
None.