Repository navigation
chore(deps): update github workflows - #8060
Open
renovate[bot] wants to merge 1 commit into
Open
renovate[bot] wants to merge 1 commit into
renovate[bot] wants to merge 1 commit into
Conversation
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
| with: | ||
| distribution: 'temurin' | ||
| java-version: '21' | ||
| java-version: '25' |
Contributor
There was a problem hiding this comment.
Java 25 can break Spark integration tests
The Tasks workflow runs Spark integration environments with Java 25. The configured PySpark 3.5.9 and 4.2.0 environments do not override JAVA_HOME, while those Spark versions document support only through Java 17 and 21, respectively. This can prevent Spark from starting and fail the integration job. Keep Java 21 until these environments are verified on Java 25 or use a compatible JDK for them.
Evidence
FRAMEWORKS_NEEDING_JAVAcontains onlyspark, andtest_group.jinjaconfigures Java 21 for groups that need it; the generated Tasks workflow now configures Java 25.tox.iniincludes Spark environments for PySpark 3.5.9 and 4.2.0, but its Java 11 override applies only to Spark 3.0.3 and 3.5.6.- The Tasks workflow runs
py${{ matrix.python-version }}-spark, so those Spark environments inherit the Java 25 installed by the workflow.
Identified by Warden · code-review, find-bugs · MFU-BC9
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit db98fbd. Configure here.
| with: | ||
| distribution: 'temurin' | ||
| java-version: '21' | ||
| java-version: '25' |
There was a problem hiding this comment.
Java 25 breaks Spark 3 tests
High Severity
Bumping java-version to 25 will fail the Spark 3.5.9 integration tests. pyspark 3.5.9 only supports Java 8, 11, and 17, and Spark 3.x still calls System.setSecurityManager, which JDK 24+ rejects. Those jobs create a SparkContext at fixture setup and will crash on startup. Spark 4.2.0 is unaffected, but 3.5.9 has no JAVA_HOME override.
Reviewed by Cursor Bugbot for commit db98fbd. Configure here.
Contributor
Coverage Results 📊✅ 133708 passed | ❌ 9 failed | ⏭️ 7276 skipped | Total: 140993 | Pass Rate: 94.83% | Execution Time: 433m 44s 📊 Comparison with Base Branch
➖ Removed Tests (58)View removed tests
✅ Patch coverage is 100.00% (no changed executable lines found; target 80%). Coverage diff@@ Coverage Diff @@
## master #8060 +/-##
==========================================
Coverage 90.26% 90.26% —%
==========================================
Files 202 202 —
Tracked lines 26660 26662 +2
Branches 9926 9928 +2
==========================================
+ Hits 24062 24064 +2
Misses 2598 2598 —
+ Partials 1510 1509 -1Generated by Coverage Action |
renovate
Bot
force-pushed
the
renovate/github-workflows
branch
from
October 20, 2026 09:02
db98fbd to
aa9ca76
Compare
| with: | ||
| distribution: 'temurin' | ||
| java-version: '21' | ||
| java-version: '25' |
Contributor
There was a problem hiding this comment.
Java version changed in generated workflow, not template
Update java-version in scripts/split_tox_gh_actions/templates/test_group.jinja (still '21') instead of this generated file, or the next split_tox_gh_actions.py run will revert it.
Evidence
- File header states this YAML is generated by
scripts/split_tox_gh_actions/split_tox_gh_actions.pyand should not be edited by hand. - Source template
scripts/split_tox_gh_actions/templates/test_group.jinjastill hardcodesjava-version: '21'. scripts/generate-test-files.shregenerates workflows from that template, which would overwrite'25'back to'21'.
Identified by Warden · code-review · PGY-PEB
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
2.35.0→2.35.17a78575→0ff758921→25Release Notes
getsentry/craft
v2.35.1Compare Source
Bug Fixes 🐛
Deps
Internal Changes 🔧
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.