Repository navigation
chore(deps): bump getsentry/craft from 2.35.0 to 3.4.1 - #6980
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [getsentry/craft](https://github.com/getsentry/craft) from 2.35.0 to 3.4.1. - [Release notes](https://github.com/getsentry/craft/releases) - [Changelog](https://github.com/getsentry/craft/blob/master/CHANGELOG.md) - [Commits](getsentry/craft@7a78575...90e8e20) --- updated-dependencies: - dependency-name: getsentry/craft dependency-version: 3.4.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
2 similar comments
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
|
|
||
| - name: Prepare release | ||
| uses: getsentry/craft@7a7857552e2cdc08b502de96e6076849c01fba32 # v2.35.0 | ||
| uses: getsentry/craft@90e8e203ad86c8ab8ee134e8d387def13e620e81 # v3.4.1 |
There was a problem hiding this comment.
craft_version does not match the pinned Craft action
The workflow pins getsentry/craft to v3.4.1, but still sets craft_version to 2.35.0. The comment says Craft cannot infer its version from the SHA ref and requires this input to match the tag, so the release job can use the stale Craft CLI. Update craft_version to 3.4.1.
Evidence
.github/workflows/release.ymlpins the action to a SHA annotatedv3.4.1at line 46.- The same step sets
craft_version: 2.35.0at line 54. - The comment directly above that input says Craft cannot get its version from a SHA ref and the value must match the SHA tag.
Identified by Warden · code-review · A6B-8FU
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5c0556c. Configure here.
|
|
||
| - name: Prepare release | ||
| uses: getsentry/craft@7a7857552e2cdc08b502de96e6076849c01fba32 # v2.35.0 | ||
| uses: getsentry/craft@90e8e203ad86c8ab8ee134e8d387def13e620e81 # v3.4.1 |
There was a problem hiding this comment.
Craft version pin not updated
High Severity
The action SHA now points at v3.4.1, but craft_version remains 2.35.0. The release job installs the CLI from that input, so prepare-release still runs Craft 2.35.0 or may fail installing that old build through the v3 action. The nearby comment says this value has to match the SHA tag. Flagged because the review guidelines call out compatibility checks on chore(deps) updates.
Additional Locations (1)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 5c0556c. Configure here.


Bumps getsentry/craft from 2.35.0 to 3.4.1.
Release notes
Sourced from getsentry/craft's releases.
... (truncated)
Changelog
Sourced from getsentry/craft's changelog.
... (truncated)
Commits
90e8e20release: 3.4.14a3ca28fix(prepare): Emit the release branch targets for the publish request (#943)b0a248dmeta: Bump new development version85d5701Merge commit '4a8dba2a45b09f4e3fcfc86a79c94d0dd93295bb'4a8dba2release: 3.4.0ef9e8e0feat(changelog): Preview PRs in every release workspace they land in (#942)1806f23meta: Bump new development versionde14162Merge commit '4b763f5419255bb520e3e5a49f5b91426dcd374d'4b763f5release: 3.3.064ef41afeat(nuget): Scope workspace expansion to the selected release workspace (#940)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)