Repository navigation
Log rewritten npm tarball URLs once per document - #538
Merged
Merged
Conversation
The npm handler logged a debug line for every version whose tarball URL it rewrote. Packages with hundreds of versions produced hundreds of lines per packument, and with cooldown enabled, where the rewrite cache is bypassed, again on every request. It now logs one line per document with the number of rewritten URLs.
andrew
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With debug logging on, the npm handler logged
rewrote tarball URLonce for every version in a packument. A package with a few hundred versions produced a few hundred lines per document, and with cooldown enabled the rewrite cache is bypassed, so that happened on every request.It now logs one line per document instead,
rewrote tarball URLswith the package and a count. The old and new URL per version are dropped; the new one is always{proxy}/npm/{package}/-/{file}.A test checks that a three-version packument logs one line with
count=3.