Repository navigation
test: give the suite a CI-sized timeout - #52
Merged
Merged
Conversation
Tests that run real builds and packed CLIs take 1-4s locally and exceed vitest's 5s default on shared CI runners. Main failed on Node 22 after #45 landed: a path-safety lifecycle test timed out while passing locally.
steve-calvert-glean
added
the
internal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI on `main` failed on Node 22.12.0 after the 0.12 fixes landed. A path-safety lifecycle test timed out at vitest's 5s default. It passes locally in under 4s. Tests that run real builds, validations and packed CLIs are slow on shared runners, not broken.
Change
Add `vitest.config.ts` with a 30s `testTimeout` for the whole suite.
Testing
`npm run check` passes locally.