Repository navigation
chore: ignore git worktrees in lint, format and tests - #53
Merged
Merged
Conversation
Running lint, format:check or the tests from a checkout with worktrees under .worktrees/ also checked every other branch's copy of the code. Ignore .worktrees/ in eslint, prettier (via .gitignore and .prettierignore) and vitest.
steve-calvert-glean
added
the
internal
steve-calvert-glean
marked this pull request as ready for review
October 22, 2026 16:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Running `npm run lint`, `npm run format:check` or `npm test` from a checkout with git worktrees under `.worktrees/` also checked every other branch's copy of the code. Lint and format failed on files from other branches, and vitest collected their tests. `.worktrees/` was only ignored through a local `.git/info/exclude`, which eslint, prettier and vitest do not read.
Change
Ignore `.worktrees/` in `eslint.config.js`, `.prettierignore`, `.gitignore` and `vitest.config.ts` (keeping vitest's default excludes).
Testing
With a probe `.worktrees/probe/` holding an unformatted file, a lint error and a failing test: before this change, lint, format:check and vitest all picked up the probe; after it, none did. `npm run check` passes.