Repository navigation
fix(watcher): always exclude the app state directory - #337
Merged
Merged
Conversation
The watcher only skipped .nextsync when a pattern matched it, and the default patterns do not include it, so every journal write re-armed the scheduler. Presenting an account reads the journals, which touches the state directory and starts another full cycle: the endless loop users see when they switch accounts. Skip the state directory unconditionally, whatever the user patterns say. Closes #324
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The watcher skipped .nextsync only when a configured pattern matched it, and the default patterns do not include it. Every journal write therefore re-armed the scheduler, and opening an account reads the journals, touches the state directory and starts another full cycle. That is the loop users see when they switch between accounts.
Skip the app state directory unconditionally, like the engine's own scan does, whatever the user patterns say. Adds a regression test with an empty matcher.
Closes #324