Repository navigation
fix(editor): continue the list when Enter is pressed mid-item - #188
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enter on a list item only continued the list when the cursor was at the end of the line. Anywhere else the handler bailed out and the plain newline left the second half of the text outside the list.
The handler now reads the whole line instead of the text up to the cursor, so it can see the marker wherever the cursor is. When the cursor sits inside the indent or the marker itself it still leaves the key alone, since there the user is editing the list syntax rather than its content. The marker and the action are decided by a pure function and the buffer work lives in
continuar_lista_en_buffer, so both are testable.Closes #186.