Repository navigation
Replace DnsMessageTransport with SimpleResolver - #3254
Merged
Merged
Conversation
Now that Nomulus runs on GKE rather than App Engine Standard, java.nio.channels.SocketChannel is supported and the custom DnsMessageTransport socket wrapper is no longer needed. - Delete DnsMessageTransport and DnsMessageTransportTest. - Provide an org.xbill.DNS.SimpleResolver (configured with TCP and dnsUpdateTimeout) via DnsUpdateWriterModule.provideResolver(). - Inject org.xbill.DNS.Resolver directly into DnsUpdateWriter. - Update DnsUpdateWriterTest to mock Resolver, add unit and loopback TCP tests for SimpleResolver integration Note: we at Google Registry generally don't use this writer; we use CloudDnsWriter instead b/463732345
gbrodman
force-pushed
the
simpleResolver
branch
from
November 2, 2026 16:39
efa2b03 to
f3b7a81
Compare
weiminyu
approved these changes
Nov 2, 2026
weiminyu
left a comment
weiminyu
left a comment
Collaborator
There was a problem hiding this comment.
@weiminyu reviewed 5 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on gbrodman).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that Nomulus runs on GKE rather than App Engine Standard, java.nio.channels.SocketChannel is supported and the custom DnsMessageTransport socket wrapper is no longer needed.
Note: we at Google Registry generally don't use this writer; we use CloudDnsWriter isntead
b/463732345
This change is