Repository navigation
Use ClassValue for ModelUtils.ALL_FIELDS_CACHE - #3257
Merged
Merged
Conversation
Replace the Caffeine LoadingCache in ModelUtils.ALL_FIELDS_CACHE with java.lang.ClassValue and narrow getAllFields return type to ImmutableMap<String, Field> Using a ClassValue instead of a cache avoids boilerplate, avoids possible memory leak issues (because it stores the values on the classes themselves), and avoids having to hash or look up anything
ptkach
approved these changes
Nov 5, 2026
ptkach
left a comment
ptkach
left a comment
Collaborator
There was a problem hiding this comment.
@ptkach reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on gbrodman).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the Caffeine LoadingCache in ModelUtils.ALL_FIELDS_CACHE with java.lang.ClassValue and narrow getAllFields return type to ImmutableMap<String, Field>
Using a ClassValue instead of a cache avoids boilerplate, avoids possible memory leak issues (because it stores the values on the classes themselves), and avoids having to hash or look up anything
This change is