Repository navigation
Silently trim registrar drive folder id - #3259
Merged
Merged
Conversation
weiminyu
enabled auto-merge
November 2, 2026 22:15
weiminyu
force-pushed
the
trim-drive-folder-id
branch
from
November 3, 2026 16:04
b023064 to
8100a2b
Compare
A registrar's driver folder id can be configured from console, and trailing whitespaces may be entered due to cut-and-paste error. This automatically silent trims such strings. The Tld's driver folder does not need this. It is configured by config files, and presubmit checks can catch trailing whitespaces. See b/580892467 for context.
weiminyu
force-pushed
the
trim-drive-folder-id
branch
from
November 3, 2026 16:04
8100a2b to
f2e76c5
Compare
gbrodman
approved these changes
Nov 3, 2026
gbrodman
left a comment
gbrodman
left a comment
Collaborator
There was a problem hiding this comment.
@gbrodman reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on weiminyu).
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 3, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A registrar's driver folder id can be configured from console, and trailing whitespaces may be entered due to cut-and-paste error. This automatically silent trims such strings.
The Tld's driver folder does not need this. It is configured by config files, and presubmit checks can catch trailing whitespaces.
See b/580892467 for context.
This change is